shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stanton Sievers" <siever...@gmail.com>
Subject Re: Review Request: Fix memory leak in IE7 for Ajax call in core.io feature using polling technique used in YUI2 connection manager
Date Sat, 21 Jul 2012 17:42:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6070/#review9332
-----------------------------------------------------------


Questions inline.


trunk/features/src/main/javascript/features/core.util.base/base.js
<https://reviews.apache.org/r/6070/#comment20016>

    This will catch all IE browsers, right?  Do we not want to poll in IE8 or newer?  Is this
check valid if ActiveX is disabled in the browser?


- Stanton Sievers


On July 21, 2012, 12:16 a.m., Henry Saputra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6070/
> -----------------------------------------------------------
> 
> (Updated July 21, 2012, 12:16 a.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> Fix memory leak in IE7 for Ajax call in core.io feature using polling technique used
in YUI2 connection manager.
> 
> The leak happen due to circular link that ajax onreadystatechange handler that has link
to the main xhr object. IE garbage collector hates that.
> 
> 
> Diffs
> -----
> 
>   trunk/config/container.js 1363863 
>   trunk/features/src/main/javascript/features/core.io/io.js 1363863 
>   trunk/features/src/main/javascript/features/core.util.base/base.js 1363863 
> 
> Diff: https://reviews.apache.org/r/6070/diff/
> 
> 
> Testing
> -------
> 
> Pass unit tests and in common container.
> 
> 
> Thanks,
> 
> Henry Saputra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message