shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marshall Shi" <shiwc...@cn.ibm.com>
Subject Re: Review Request: Ambiguous error message when gadgets are not whitelisted
Date Fri, 20 Jul 2012 00:31:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6041/
-----------------------------------------------------------

(Updated July 20, 2012, 12:31 a.m.)


Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.


Description
-------

In Shindig when using gadget whitelisting and feature access control, there are two error
messages:

1. Gadget is not whitelisted:
403 The requested gadget is unavailable

2. Gadget is requesting features that it does not have access too
400 The requested gadget is not authorized for this container

The second error is perfect as it tells me that it has been rejected due to an authorization
error AND that it may be config related (Type 400 response).

The first error is ambiguous however, as it looks almost exactly the same as when the server
that provides the gadget.xml is unavailable and / or rejects the request. Please change (1)
to something like:
403 The requested gadget is not authorized for this container
This will tell the user that the gadget is both not authorized and via the response code (403)
that it is missing from the whitelist entirely. 


This addresses bug shindig-1818.
    https://issues.apache.org/jira/browse/shindig-1818


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java
1341759 

Diff: https://reviews.apache.org/r/6041/diff/


Testing
-------


Thanks,

Marshall Shi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message