shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Clarke" <cla...@gmail.com>
Subject Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT
Date Wed, 18 Jul 2012 19:45:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6035/
-----------------------------------------------------------

(Updated July 18, 2012, 7:45 p.m.)


Review request for shindig, Ryan Baxter and Stanton Sievers.


Changes
-------

Wrong JIRA


Description
-------

Adds two new settings to oauth.json (or other persistence plugins) to handle picky OAuth1.0a
providers.

1) New key_type "PLAINTEXT"
   "key_type" : "PLAINTEXT"
Default remains "key_type" : "HMAC_SYMMETRIC"

2) New field "bodyHash" that won't put extra params like "oauth_body_hash" on requests
   "bodyHash" : "false"
Default is "true" to keep compatibility with existing configurations


This addresses bug SHINDIG-1775.
    https://issues.apache.org/jira/browse/SHINDIG-1775


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java
1363028 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStoreConsumerKeyAndSecret.java
1363028 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
1363028 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java
1363028 

Diff: https://reviews.apache.org/r/6035/diff/


Testing
-------

All JUnits pass.


Thanks,

Adam Clarke


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message