shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Dumont" <ddum...@us.ibm.com>
Subject Re: Review Request: Unserializable cache keys
Date Wed, 11 Jul 2012 15:45:23 GMT


> On July 5, 2012, 7:27 p.m., Ryan Baxter wrote:
> > Committed revision 1357819.

Erik, please close this review.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5693/#review8888
-----------------------------------------------------------


On July 3, 2012, 2:17 a.m., Erik Bi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5693/
> -----------------------------------------------------------
> 
> (Updated July 3, 2012, 2:17 a.m.)
> 
> 
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
> 
> 
> Description
> -------
> 
> Unserializable cache keys?
> 
> Right now the Shindig Caches the 'messageBundles' and 'gadgetSpecs' with Uri object as
key, but for some cache implementation, for example, DynaCache, it requires the key to be
serializable, which Uri is not. 
> 
> There are two solution for this, one, make Uri serializable 2. using a 'string' for the
key, uri.toString is good enough. 
> 
> Propose to use "string" because Uri is a complex object that includes a Uri parsers so
you would need to be very careful to get it right.  It would be trivial to use a string key
instead.
> 
> 
> This addresses bug SHINDIG-1814.
>     https://issues.apache.org/jira/browse/SHINDIG-1814
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java
1345812 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java
1345812 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultMessageBundleFactory.java
1345812 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactoryTest.java
1345812 
> 
> Diff: https://reviews.apache.org/r/5693/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erik Bi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message