shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Baxter" <rbaxte...@gmail.com>
Subject Re: Review Request: Change the check for child RPC to also verify if parent url parameter exists
Date Mon, 09 Jul 2012 21:26:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5810/#review8988
-----------------------------------------------------------

Ship it!


LGTM, when you close the JIRA could you make sure you mark it fixed for 2.5.0 beta3?  Thanks.

- Ryan Baxter


On July 9, 2012, 6:59 p.m., Henry Saputra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5810/
> -----------------------------------------------------------
> 
> (Updated July 9, 2012, 6:59 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> The Shindig container could be rendered inside parent iframe and in this scenario, the
rpc check for isChild (almost the same as check fro isGadget) does not work well because its
actually act as the real container even though its put inside another iframe.
> 
> The proposed fix to add check for url param "parent" as well as the check for window
instance.
> 
> 
> This addresses bug SHINDIG-1816.
>     https://issues.apache.org/jira/browse/SHINDIG-1816
> 
> 
> Diffs
> -----
> 
>   trunk/features/src/main/javascript/features/rpc/rpc.js 1356941 
> 
> Diff: https://reviews.apache.org/r/5810/diff/
> 
> 
> Testing
> -------
> 
> Unit tests still pass. Common container renders gadgets and rpc works as expected.
> 
> 
> Thanks,
> 
> Henry Saputra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message