shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Saputra" <>
Subject Re: Review Request: Change the check for child RPC to also verify if parent url parameter exists
Date Mon, 09 Jul 2012 18:29:08 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 9, 2012, 6:29 p.m.)

Review request for shindig.


Update the patch based on Ryan and Stanton inputs:
-) Remove the if else for checking if child
-) Change to window.frames because common container can be put inside an


The Shindig container could be rendered inside parent iframe and in this scenario, the rpc
check for isChild (almost the same as check fro isGadget) does not work well because its actually
act as the real container even though its put inside another iframe.

The proposed fix to add check for url param "parent" as well as the check for window instance.

Diffs (updated)

  trunk/features/src/main/javascript/features/rpc/rpc.js 1356941 



Unit tests still pass. Common container renders gadgets and rpc works as expected.


Henry Saputra

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message