shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Saputra" <hsapu...@apache.org>
Subject Re: Review Request: Change the check for child RPC to also verify if parent url parameter exists
Date Sun, 08 Jul 2012 21:36:23 GMT


> On July 8, 2012, 7:30 p.m., Ryan Baxter wrote:
> > trunk/features/src/main/javascript/features/rpc/rpc.js, line 130
> > <https://reviews.apache.org/r/5810/diff/1/?file=119906#file119906line130>
> >
> >     Do we need the if else here?

I guess we dont =)

Will update the proposed patch


- Henry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5810/#review8952
-----------------------------------------------------------


On July 6, 2012, 6:11 p.m., Henry Saputra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5810/
> -----------------------------------------------------------
> 
> (Updated July 6, 2012, 6:11 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> The Shindig container could be rendered inside parent iframe and in this scenario, the
rpc check for isChild (almost the same as check fro isGadget) does not work well because its
actually act as the real container even though its put inside another iframe.
> 
> The proposed fix to add check for url param "parent" as well as the check for window
instance.
> 
> 
> Diffs
> -----
> 
>   trunk/features/src/main/javascript/features/rpc/rpc.js 1356941 
> 
> Diff: https://reviews.apache.org/r/5810/diff/
> 
> 
> Testing
> -------
> 
> Unit tests still pass. Common container renders gadgets and rpc works as expected.
> 
> 
> Thanks,
> 
> Henry Saputra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message