shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Dumont" <ddum...@us.ibm.com>
Subject Re: Review Request: if shindig-container feature is included, it overwrites all of the osapi.container functions created by container feature.
Date Thu, 08 Mar 2012 13:58:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4239/#review5720
-----------------------------------------------------------


shindig-container and container are mutually exclusive features, I really don't think they
were ever intended to be used together, so I'm hesitant to see this changed.

- Dan


On 2012-03-08 06:31:13, hu jian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4239/
> -----------------------------------------------------------
> 
> (Updated 2012-03-08 06:31:13)
> 
> 
> Review request for shindig, Henry Saputra, li xu, and Dan Dumont.
> 
> 
> Summary
> -------
> 
> if shindig-container feature is included, it overwrites all of the osapi.container functions
created by container feature. 
> shindig.container/osapi.js should at the very least check that osapi.container doesn't
ready exist before overwriting it to {}. 
> shindig.container/feature.xml should also be altered to reflect the addition of osapi.container.listMethods
> 
> 
> This addresses bug SHINDIG-1724.
>     https://issues.apache.org/jira/browse/SHINDIG-1724
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.container/feature.xml
1298262 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.container/osapi.js
1298262 
> 
> Diff: https://reviews.apache.org/r/4239/diff
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> hu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message