shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yao Zhang" <yaozyzhang2...@gmail.com>
Subject Review Request: rpc does not support communicating with gadget created on an dom node in existing iframe
Date Wed, 15 Feb 2012 04:09:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3908/
-----------------------------------------------------------

Review request for shindig, Henry Saputra, Dan Dumont, and Stanton Sievers.


Summary
-------

When you try to render a gadget to a dom node inside an existing iframe, rpc does not work
as the code is using document.getElementById to get the domnode


This addresses bug SHINDIG-1704.
    https://issues.apache.org/jira/browse/SHINDIG-1704


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js
1238149 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
1238149 

Diff: https://reviews.apache.org/r/3908/diff


Testing
-------


Thanks,

Yao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message