shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Lindner" <lind...@inuus.com>
Subject Re: Review Request: A patch that enables API for updating person data
Date Tue, 07 Feb 2012 17:23:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3544/#review4864
-----------------------------------------------------------

Ship it!


lgtm -- modulo trailing whitespace.


- Paul


On 2012-02-07 10:42:50, Evgeny Bogdanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3544/
> -----------------------------------------------------------
> 
> (Updated 2012-02-07 10:42:50)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> A patch that enables API for updating person data
> PUT people/12/@self
> osapi.people.update()
> 
> 
> for this JIRA reports
> https://issues.apache.org/jira/browse/SHINDIG-1674
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java
1241411 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java
1241411 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java
1241411 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java
1241411 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml
1241411 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java
1241411 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java
1241411 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
1241411 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java
1241411 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java
1241411 
> 
> Diff: https://reviews.apache.org/r/3544/diff
> 
> 
> Testing
> -------
> 
> tests are in the patch
> 
> 
> Thanks,
> 
> Evgeny
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message