Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@shindig.apache.org
Received-SPF: pass (athena.apache.org: local policy)
User-Agent: Microsoft-Entourage/12.32.0.111121
Date: Fri, 27 Jan 2012 15:25:04 -0500
Subject: Re: OAuth2RequestParameterGenerator
From: daviesd <daviesd@oclc.org>
To: shindig <dev@shindig.apache.org>
Message-ID: <CB487250.D59B%daviesd@oclc.org>
Thread-Topic: OAuth2RequestParameterGenerator
Thread-Index: AczdKTY4zbsUhq8hs0uw0cXOsu+/DAACIpM2
In-Reply-To: <CB4863FC.D587%daviesd@oclc.org>
Mime-version: 1.0
Content-type: multipart/alternative;
	boundary="B_3410522704_19931442"

--B_3410522704_19931442
Content-type: text/plain;
	charset="ISO-8859-1"
Content-transfer-encoding: quoted-printable

I=B9m just wondering if it=B9s as easy as having BasicHttpFetcher transfer the
HttpRequest params to the httpMethod params.  Was it an oversight or were
they not copied for a reason?

doug

On 1/27/12 2:23 PM, "daviesd" <daviesd@oclc.org> wrote:

> Back in December Li Xu helped me get a patch submitted that added the
> OAuth2RequestParameterGenerator interface.  It is meant to be implemented=
 if
> you want to pass additional parameters along to the various oauth2 flow
> requests.
>=20
> I=B9ve since noticed an issue with this.  The parameters I add get passed a=
long
> fine to a CodeGrantTypeHandler (when asking for the auth code).  However,=
 when
> the access token is requested using the StandardAuthenticationHandler, th=
e
> parameters I generate do not get passed along the subsequent
> BasicHttpFetcher.fetch.  I think probably because this is a POST and it
> doesn=B9t pass parameters sent in the HttpRequest object.  It assumes only
> header values?  Is this correct or a bug?  Should I be passing my additio=
nal
> parameters along in the header in this case?  If so, I probably need to s=
upply
> a patch for StandardAuthenticationHandler that adds the params to the hea=
der
> in addition.
>=20
>       request.setHeader(OAuth2Message.CLIENT_ID, clientId);
>       request.setParam(OAuth2Message.CLIENT_ID, clientId);
>       request.setHeader(OAuth2Message.CLIENT_SECRET, secret);
>       request.setParam(OAuth2Message.CLIENT_SECRET, secret);
>=20
>       // add any additional parameters
>       for (Map.Entry<String, String> entry :
> accessor.getAdditionalRequestParams().entrySet()) {
>         request.setParam(entry.getKey(), entry.getValue());
>       }
>=20
> doug


--B_3410522704_19931442--