Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0781D9FD7 for ; Mon, 30 Jan 2012 05:07:27 +0000 (UTC) Received: (qmail 58057 invoked by uid 500); 30 Jan 2012 05:07:26 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 57824 invoked by uid 500); 30 Jan 2012 05:07:17 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 57803 invoked by uid 99); 30 Jan 2012 05:07:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jan 2012 05:07:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3A77C1C00B2; Mon, 30 Jan 2012 05:07:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1638908769529495798==" MIME-Version: 1.0 Subject: Re: Review Request: gadgets.metadata request fails for gadgets that don't have a "default" view From: "Henry Saputra" To: "shindig" , "Ryan Baxter" , "Henry Saputra" Date: Mon, 30 Jan 2012 05:07:08 -0000 Message-ID: <20120130050708.20133.65371@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3670/ In-Reply-To: <20120128011722.8384.21831@reviews.apache.org> References: <20120128011722.8384.21831@reviews.apache.org> --===============1638908769529495798== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3670/#review4683 ----------------------------------------------------------- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/= features/container.util/util.js I think we could just call this "iframeUrls". Should be implicitly impl= y all for the metadata call since we dont pass any view param. - Henry On 2012-01-28 01:17:22, Ryan Baxter wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3670/ > ----------------------------------------------------------- > = > (Updated 2012-01-28 01:17:22) > = > = > Review request for shindig. > = > = > Summary > ------- > = > The request for gadgets.metadata fails for a gadget spec that doesn't spe= cify a "default" view. > = > = > This addresses bug SHINDIG-1549. > https://issues.apache.org/jira/browse/SHINDIG-1549 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/jav= a/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/jav= a/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/jav= a/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/jav= a/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/uri/IframeUriManager.java 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container.site.gadget/gadget_holder.js 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container.util/constant.js 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container.util/util.js 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascr= ipt/features/container/gadget_holder_test.js 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1236884 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/jav= a/org/apache/shindig/gadgets/uri/UriManagerTestBase.java 1236884 = > = > Diff: https://reviews.apache.org/r/3670/diff > = > = > Testing > ------- > = > Updated unit tests and tested in the various containers > = > = > Thanks, > = > Ryan > = > --===============1638908769529495798==--