Return-Path: X-Original-To: apmail-shindig-dev-archive@www.apache.org Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7FBC99357 for ; Fri, 13 Jan 2012 15:03:51 +0000 (UTC) Received: (qmail 7926 invoked by uid 500); 13 Jan 2012 15:03:51 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 7810 invoked by uid 500); 13 Jan 2012 15:03:50 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 7788 invoked by uid 99); 13 Jan 2012 15:03:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jan 2012 15:03:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D88D81C086E; Fri, 13 Jan 2012 15:03:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8225448332982918206==" MIME-Version: 1.0 Subject: Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire. From: "Dan Dumont" To: "Jesse Ciancetta" , "li xu" , "Ryan Baxter" , "Stanton Sievers" , "Henry Saputra" Date: Fri, 13 Jan 2012 15:03:49 -0000 Message-ID: <20120113150349.6698.73936@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3180/ Cc: "shindig" ,"Dan Dumont" In-Reply-To: <20120112232546.6698.37660@reviews.apache.org> References: <20120112232546.6698.37660@reviews.apache.org> --===============8225448332982918206== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2012-01-12 23:25:46, Ryan Baxter wrote: > > Looks like you added some additional methods to gadget site and contain= er util, do you want to also make the corresponding changes in the feature.= xml files as well? I think I've declared all of the ones I wanted to be public in the features= .xml. That file is just to assist in exports and closure process, right? Or do = all methods used in other files need to be called out there? > On 2012-01-12 23:25:46, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container.gadget/gadget_site.js, line 84 > > > > > > Maybe I am missing something here but you seem to be saying you can= pass in the module id in args but here you are setting it to 0 instead of = checking if its in the args Whoops. I'll edit that comment. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/#review4339 ----------------------------------------------------------- On 2012-01-10 20:53:59, Dan Dumont wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3180/ > ----------------------------------------------------------- > = > (Updated 2012-01-10 20:53:59) > = > = > Review request for shindig, Henry Saputra, Ryan Baxter, li xu, Jesse Cian= cetta, and Stanton Sievers. > = > = > Summary > ------- > = > Initial review of 1st change. Allowing common container to manage contai= ner token refreshes. Also, refresh of gadget security tokens will now wait= for valid container security token before trying to refresh. > = > = > This addresses bug SHINDIG-1681. > https://issues.apache.org/jira/browse/SHINDIG-1681 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/e= xamples/commoncontainer/assembler.js 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container.gadget/gadget_holder.js 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container.gadget/gadget_site.js 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container.util/constant.js 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container.util/feature.xml 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container.util/util.js 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container/container.js 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container/feature.xml 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascr= ipt/features/container/service.js 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascr= ipt/features/container/gadget_holder_test.js 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascr= ipt/features/container/service_test.js 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/servlet/ModuleIdManager.java PRE-CREATION = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/jav= a/org/apache/shindig/gadgets/servlet/ModuleIdManagerImpl.java PRE-CREATION = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/jav= a/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1222407 = > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/jav= a/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1222407 = > = > Diff: https://reviews.apache.org/r/3180/diff > = > = > Testing > ------- > = > Tested code in a private container with some examples of setting no refre= sh (ttl =3D 0) and setting an initial token (if it was written by jsp page = to avoid transaction) etc.. > = > = > Thanks, > = > Dan > = > --===============8225448332982918206==--