Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@shindig.apache.org
Content-Type: multipart/alternative;
	boundary="===============7817328341300335427=="
MIME-Version: 1.0
Subject: Re: Review Request: Add test gadget to the common container sample to
 test
 domain configuration
From: "Stanton Sievers" <sieverssj@gmail.com>
To: "Jasvir Nagra" <jasvir@gmail.com>
Date: Tue, 03 Jan 2012 15:18:36 -0000
Message-ID: <20120103151836.3461.57598@reviews.apache.org>
Cc: "shindig" <dev@shindig.apache.org>,
 "Stanton Sievers" <sieverssj@gmail.com>,
	"Dan Dumont" <ddumont@us.ibm.com>, "Paul Lindner" <lindner@inuus.com>
In-Reply-To: <20111229223454.17094.46898@reviews.apache.org>
References: <20111229223454.17094.46898@reviews.apache.org>

--===============7817328341300335427==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3334/
-----------------------------------------------------------

(Updated 2012-01-03 15:18:36.205998)


Review request for shindig and Jasvir Nagra.


Changes
-------

Added license boilerplate to the gadget.  Added Jasvir for his input.


Summary
-------

This is the first of a couple of gadgets I'd like to commit that can act as=
 unit tests for testing deployment configurations, such as locked domains a=
nd security token encryption. =


This particular gadget simply tries to get at container information (the lo=
cation) from within the gadget.  In a properly configured environment this =
should be disallowed due to browser same-origin policy.

Can anyone else think of anything that this gadget should be testing?  Curr=
ently it will simply try to get at the parent window's location and then wi=
ll keep lowering its domain to try to match that of the container's.  =


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/exa=
mples/ContainerGadgetDomainTest.xml PRE-CREATION =

  http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/exa=
mples/commoncontainer/gadgetCollections.json 1226796 =


Diff: https://reviews.apache.org/r/3334/diff


Testing
-------

Container: localhost, Gadget: localhost, Result: Fail
Container: container.foobar.com, Gadget: gadgets.foobar.com, Result: Success
Container: foobar.com, Gadget: gadgets.foobar.com, Result: Fail (when the c=
ontainer page has set document.domain to location.hostname)

And I'm sure I tried some other things as well. :)


Thanks,

Stanton


--===============7817328341300335427==--