shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Baxter" <rbaxte...@gmail.com>
Subject Re: Review Request: SHINDIG-1686 The gadgets.views.init does not check for the view name if it contains secondary view
Date Mon, 30 Jan 2012 16:55:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3666/#review4691
-----------------------------------------------------------

Ship it!


LGTM

- Ryan


On 2012-01-27 22:11:34, Henry Saputra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3666/
> -----------------------------------------------------------
> 
> (Updated 2012-01-27 22:11:34)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> See jira: SHINDIG-1686 (https://issues.apache.org/jira/browse/SHINDIG-1686) for detail
about the issue.
> 
> 
> This addresses bug SHINDIG-1686.
>     https://issues.apache.org/jira/browse/SHINDIG-1686
> 
> 
> Diffs
> -----
> 
>   trunk/features/src/main/javascript/features/views/views.js 1236784 
>   trunk/features/src/test/javascript/features/views/views-init-test.js 1236784 
> 
> Diff: https://reviews.apache.org/r/3666/diff
> 
> 
> Testing
> -------
> 
> Modify the JS unit test to test the subview. Run simple apps in common container with
different views and subviews.
> 
> 
> Thanks,
> 
> Henry
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message