shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ate Douma" <...@douma.nu>
Subject Re: Review Request: Maven project enhancements to improve embedding and extending shindig-server
Date Mon, 30 Jan 2012 13:38:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3695/
-----------------------------------------------------------

(Updated 2012-01-30 13:38:57.710474)


Review request for shindig.


Changes
-------

Updated and fixed patch. Turned out getting source moves encoded properly in an svn diff is
even more tricky than expected.
Furthermore, Review Board doesn't seem to understand/recognize only summarized svn deletes
(as produced with svn diff parameter --no-diff-deleted).

FYI: this newest patch was made anew using a slightly different ordering of the steps, and
generating the patch using: svn diff --show-copies-as-adds 


Summary
-------

This is an *artificial* patch showing the *end* result of the proposed changes.
These changes assume several source *moves*, which cannot be reliably captured as an svn diff.
If this patch is accepted, it probably is best to do (part of) the proposed steps as described
in https://issues.apache.org/jira/browse/SHINDIG-1691 manually.

Note: I've created this patch using svn 1.7.2 with (1.7+ only) command parameters: svn diff
--show-copies-as-adds --no-diff-deleted 


This addresses bug SHINDIG-1691.
    https://issues.apache.org/jira/browse/SHINDIG-1691


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/sample-container/src/main/java/org/apache/shindig/sample/container/SampleContainerGuiceModule.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/java/sample-container/src/main/java/org/apache/shindig/sample/container/SampleContainerHandler.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/java/sample-container/src/main/java/org/apache/shindig/sample/shiro/SampleShiroRealm.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/java/sample-container/src/main/java/org/apache/shindig/sample/shiro/ShiroGuiceModule.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/authorize.jsp
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/login.jsp
PRE-CREATION 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server/pom.xml 1237607 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/java/org/apache/shindig/sample/container/SampleContainerGuiceModule.java
1237607 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/java/org/apache/shindig/sample/container/SampleContainerHandler.java
1237607 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/java/org/apache/shindig/sample/shiro/SampleShiroRealm.java
1237607 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/java/org/apache/shindig/sample/shiro/ShiroGuiceModule.java
1237607 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/authorize.jsp
1237607 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml
1237607 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/login.jsp 1237607

  http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1237607 

Diff: https://reviews.apache.org/r/3695/diff


Testing
-------


Thanks,

Ate


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message