shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Dumont" <ddum...@us.ibm.com>
Subject Re: Review Request: Publish global selection into the DataContext of a gadget (if available)
Date Fri, 27 Jan 2012 21:12:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3668/
-----------------------------------------------------------

(Updated 2012-01-27 21:12:09.770883)


Review request for shindig and Andrew Davis.


Changes
-------

Ryan, I thought you had meant the constant name, not the key name.   Fixed.


Summary
-------

This review is mostly for Mark.

Hopefully this change will supply the template code with all it needs to work with selection.
  A good starting point at least.


This addresses bug SHINDIG-1690.
    https://issues.apache.org/jira/browse/SHINDIG-1690


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js
1236266 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js
1236266 

Diff: https://reviews.apache.org/r/3668/diff


Testing
-------

Built fine, all tests pass.  I don't have any gadgets to run against right now.   Hoping to
have Mark try it out.   (you don't seem to have an account on here, Mark.  I couldn't add
you as a reviewer)


Thanks,

Dan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message