shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Baxter" <rbaxte...@gmail.com>
Subject Re: Review Request: Publish global selection into the DataContext of a gadget (if available)
Date Fri, 27 Jan 2012 21:06:13 GMT


> On 2012-01-27 21:00:21, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js,
line 166
> > <https://reviews.apache.org/r/3668/diff/1/?file=71118#file71118line166>
> >
> >     usually keys from the spec start with org.opensocial.*, we should probably follow
the same pattern
> 
> Dan Dumont wrote:
>     Ok.  I've no opinion about this key lives. I (or someone) can move it when the spec
for this feature is decided upon, if this is the agreed upon approach.

If we know it is going to start with org.opensocial why not change it to match so we dont
have to change it later.  Something like org.opensocial.selection should work.  For example
for embedded experiences we use org.opensocial.ee.context.


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3668/#review4658
-----------------------------------------------------------


On 2012-01-27 20:52:24, Dan Dumont wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3668/
> -----------------------------------------------------------
> 
> (Updated 2012-01-27 20:52:24)
> 
> 
> Review request for shindig and Andrew Davis.
> 
> 
> Summary
> -------
> 
> This review is mostly for Mark.
> 
> Hopefully this change will supply the template code with all it needs to work with selection.
  A good starting point at least.
> 
> 
> This addresses bug SHINDIG-1690.
>     https://issues.apache.org/jira/browse/SHINDIG-1690
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js
1236266 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js
1236266 
> 
> Diff: https://reviews.apache.org/r/3668/diff
> 
> 
> Testing
> -------
> 
> Built fine, all tests pass.  I don't have any gadgets to run against right now.   Hoping
to have Mark try it out.   (you don't seem to have an account on here, Mark.  I couldn't add
you as a reviewer)
> 
> 
> Thanks,
> 
> Dan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message