shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Baxter" <rbaxte...@gmail.com>
Subject Re: Review Request: SHINDIG-1678 The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container
Date Thu, 26 Jan 2012 00:56:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3566/#review4617
-----------------------------------------------------------

Ship it!


LGTM

- Ryan


On 2012-01-25 19:57:26, Henry Saputra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3566/
> -----------------------------------------------------------
> 
> (Updated 2012-01-25 19:57:26)
> 
> 
> Review request for shindig and johnfargo.
> 
> 
> Summary
> -------
> 
> See "SHINDIG-1678 The flash transport to support RPC for IE7 has problem with multiple
gadgets in a single container" https://issues.apache.org/jira/browse/SHINDIG-1678 for detail
description about the review.
> 
> Proposed fix is to flush the handshakes objects whenever new gadgets call gadgets.rpc.setupReceiver
is called to make sure the container side register the child iframe info to the flash component.
> 
> 
> This addresses bug SHINDIG-1678.
>     https://issues.apache.org/jira/browse/SHINDIG-1678
> 
> 
> Diffs
> -----
> 
>   trunk/features/src/main/javascript/features/rpc/flash.transport.js 1234681 
> 
> Diff: https://reviews.apache.org/r/3566/diff
> 
> 
> Testing
> -------
> 
> Running multiple gadgets in common container in IE7
> 
> 
> Thanks,
> 
> Henry
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message