shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Dumont" <ddum...@us.ibm.com>
Subject Re: Review Request: Need to expose OAuth2 metadata to the container
Date Mon, 23 Jan 2012 14:34:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3571/#review4534
-----------------------------------------------------------

Ship it!


LGTM after whitespace fixes


trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
<https://reviews.apache.org/r/3571/#comment10126>

    Indentation seems like it's set very high.
    The shindig imports have indentation at 2 spaces.
    
    same for OAuth2Service interface below.


- Dan


On 2012-01-20 19:47:21, Igor Belakovskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3571/
> -----------------------------------------------------------
> 
> (Updated 2012-01-20 19:47:21)
> 
> 
> Review request for shindig and Henry Saputra.
> 
> 
> Summary
> -------
> 
> Need to expose OAuth2 metadata to the container, similar to https://issues.apache.org/jira/browse/SHINDIG-1616
where we exposed Oauth 1.0 data. 
> 
> 
> Diffs
> -----
> 
>   trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
1232531 
>   trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
1232531 
> 
> Diff: https://reviews.apache.org/r/3571/diff
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Igor
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message