shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Baxter" <rbaxte...@gmail.com>
Subject Review Request: Revert SHINDIG-1669
Date Fri, 06 Jan 2012 02:10:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3402/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

SHINDIG-1669 is not working as expected in all situations and is causing to many failures,
best to revert it for now until we come up with a better solution.  The only file I did not
revert is viewenhancements-container.js because those changes were for other bugs.


This addresses bug SHINDIG-1679.
    https://issues.apache.org/jira/browse/SHINDIG-1679


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml
1227888 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
1227888 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1227888 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
1227888 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/container_url_test.js
1227888 

Diff: https://reviews.apache.org/r/3402/diff


Testing
-------

Ran unit tests and tested in the sample common container and embedded experiences container.


Thanks,

Ryan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message