shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stanton Sievers" <siever...@gmail.com>
Subject Re: Review Request: Add additional lifecycle handlers
Date Fri, 18 Nov 2011 21:51:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/#review3363
-----------------------------------------------------------

Ship it!


A few questions, but LGTM.


http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
<https://reviews.apache.org/r/2616/#comment7542>

    Do actions not care about the ON_CLOSED event anymore?



http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js
<https://reviews.apache.org/r/2616/#comment7543>

    Same as actions... do we not care about ON_CLOSED anymore?


- Stanton


On 2011-11-18 21:16:31, Ryan Baxter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2616/
> -----------------------------------------------------------
> 
> (Updated 2011-11-18 21:16:31)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> I have added additional lifecycle handlers.  My primary use case here is to be able to
time the different events that take place as a gadget is rendered, but these additional lifecycle
handlers may be used for other things as well.
> 
> 
> This addresses bug SHINDIG-1653.
>     https://issues.apache.org/jira/browse/SHINDIG-1653
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js
1203746 
>   http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
1203746 
>   http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js
1203746 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
1203746 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
1203746 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
1203746 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js
1203746 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1203746 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js
1203746 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js
1203746 
>   http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js
1203746 
> 
> Diff: https://reviews.apache.org/r/2616/diff
> 
> 
> Testing
> -------
> 
> Modified sample container to log this information and updated unit tests.
> 
> 
> Thanks,
> 
> Ryan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message