shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stanton Sievers" <siever...@gmail.com>
Subject Re: Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.
Date Mon, 14 Nov 2011 21:24:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2824/#review3236
-----------------------------------------------------------

Ship it!


Good stuff.  Thanks Jesse!

- Stanton


On 2011-11-14 20:46:51, Jesse Ciancetta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2824/
> -----------------------------------------------------------
> 
> (Updated 2011-11-14 20:46:51)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> Update the ContainerConfig stack to allow for res://some-resource.txt and file:///some-file.txt
style values in container.js and automatically resolve these references during initialization.
This allows us to refactor BlobCrypterSecurityTokenCodec to expect to be given the actual
encryption key rather than a key or resource pointer as it does currently.
> 
> This also opens the door for this functionality to be used for other configuration which
we'd like to load from external files (which should be useful for third party implementers).
> 
> 
> This addresses bug shindig-1660.
>     https://issues.apache.org/jira/browse/shindig-1660
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1201745 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java
1201745 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/DefaultSecurityTokenCodec.java
1201745 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/util/ResourceLoader.java
1201745 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/config/JsonContainerConfigLoader.java
1201745 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java
1201745 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/DefaultSecurityTokenCodecTest.java
1201745 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/config/JsonContainerConfigLoaderTest.java
1201745 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/resources/classpath-accessible-test-file.txt
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/2824/diff
> 
> 
> Testing
> -------
> 
> Updated/added tests.  Ran build, verified unit tests and tested common container.
> 
> 
> Thanks,
> 
> Jesse
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message