shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "li xu" <leeg...@gmail.com>
Subject Review Request: Enable shindig.signing.global-callback-url to support any host/port
Date Fri, 05 Aug 2011 15:08:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1305/
-----------------------------------------------------------

Review request for shindig, Paul Lindner, Henry Saputra, johnfargo, and Eric Woods.


Summary
-------

Defect: "shindig.signing.global-callback-url" in shindig.properties file can only be defined
with explicit host/port
This fix will allow host/port to be resolved automatically when using default OAuth support
we ship out of box.
old 
shindig.signing.global-callback-url=http://localhost:8080%contextRoot%/gadgets/oauthcallback
new
shindig.signing.global-callback-url=http://%authority%%contextRoot%/gadgets/oauthcallback
OAuthStore provider could use hostProvider to resolve the authority. 


Diffs
-----

  /trunk/java/common/conf/shindig.properties 1148035 
  /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java
1146102 
  /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthModule.java 1146102

  /trunk/java/server/src/main/webapp/WEB-INF/web.xml 1146102 

Diff: https://reviews.apache.org/r/1305/diff


Testing
-------

unit test is done.
tested an OAuth Gadget with OAuth service provider.


Thanks,

li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message