Return-Path: Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: (qmail 88426 invoked from network); 9 Mar 2011 20:39:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Mar 2011 20:39:38 -0000 Received: (qmail 56147 invoked by uid 500); 9 Mar 2011 20:39:38 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 56124 invoked by uid 500); 9 Mar 2011 20:39:38 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 56113 invoked by uid 99); 9 Mar 2011 20:39:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Mar 2011 20:39:38 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of mhermanto@gmail.com designates 209.85.215.52 as permitted sender) Received: from [209.85.215.52] (HELO mail-ew0-f52.google.com) (209.85.215.52) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Mar 2011 20:39:32 +0000 Received: by ewy28 with SMTP id 28so325936ewy.39 for ; Wed, 09 Mar 2011 12:39:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=2/wNJe1XLTp+jXR5Ldd//ukDSLRQe2IR5ilA+bIZkRY=; b=HCGO5Jp+DDqNQ/x/1E5KOT05pduTK4mYRXnjaXm/QYqL9bkyn2pdKLvALZQNt69I18 dfisuPgWoXarkjTuvE1joGykIHTZVgEFTo/DP/j9ow+bB8R6eET33HceFWEg4DJzzZJE TNT5E4l70diByed7k2VOC2iIa94pcFdgWTI3I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=NKUcRYc8eCTuKh73LWCWJSxosOO66iAEe0JP/1BgNO/ZODsWvsaqyS4KxGZHTM0aS6 6vXoG30DHVToYIUf6JDelxbF1pDc8aB+ACLKURTqUOWFMtBMQ39hXU0FGStsbxdoEZyQ Zw94gyeQ9I+Fh9MJsG53VkynEpL9YeVhXnfhU= MIME-Version: 1.0 Received: by 10.14.20.4 with SMTP id o4mr2388747eeo.6.1299703150932; Wed, 09 Mar 2011 12:39:10 -0800 (PST) Received: by 10.14.37.73 with HTTP; Wed, 9 Mar 2011 12:39:10 -0800 (PST) In-Reply-To: <00151774059a8a29fa049e127edd@google.com> References: <00151774059a8a29fa049e127edd@google.com> Date: Wed, 9 Mar 2011 12:39:10 -0800 Message-ID: Subject: Re: Allow extensions to the common container by allowing other features to provide their own namespace (issue4260049) From: Michael Hermanto To: rbaxter85@gmail.com, mhermanto@gmail.com, dev@shindig.apache.org, dev-remailer@shindig.apache.org, fargo@google.com, reply@codereview.appspotmail.com Content-Type: multipart/alternative; boundary=0016e6d589639ff57a049e12b866 --0016e6d589639ff57a049e12b866 Content-Type: text/plain; charset=ISO-8859-1 LGTM, submit away. :) Nit, I still see indentation as more than 2 spaces (perhaps, it's just codereview). On Wed, Mar 9, 2011 at 12:22 PM, wrote: > Updated patch with Mike's suggestion > > > http://codereview.appspot.com/4260049/ > --0016e6d589639ff57a049e12b866--