Return-Path: Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: (qmail 39707 invoked from network); 6 Sep 2010 11:23:41 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 6 Sep 2010 11:23:41 -0000 Received: (qmail 46827 invoked by uid 500); 6 Sep 2010 11:23:41 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 46705 invoked by uid 500); 6 Sep 2010 11:23:38 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Delivered-To: moderator for dev@shindig.apache.org Received: (qmail 45808 invoked by uid 99); 4 Sep 2010 06:55:23 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of 3L-2BTA0JA-oTQZdk.eMbgfdMSYMUX.OaYPQheTUZPUS.MbMOTQ.adS@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.210.70 as permitted sender) MIME-Version: 1.0 Reply-To: henry.saputra@gmail.com, dev-remailer@shindig.apache.org, dev@shindig.apache.org, lindner@inuus.com, reply@codereview.appspotmail.com X-Google-Appengine-App-Id: codereview Message-ID: <0016363b7b086e7198048f698554@google.com> Date: Sat, 04 Sep 2010 06:54:39 +0000 Subject: Re: Separate JS content processing logic from JsServlet (issue2104046) From: henry.saputra@gmail.com To: dev-remailer@shindig.apache.org, dev@shindig.apache.org, lindner@inuus.com Cc: reply@codereview.appspotmail.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes X-Virus-Checked: Checked by ClamAV on apache.org Resolve issue/suggestions from Paul. Uploaded the latest patch file. - Henry http://codereview.appspot.com/2104046/diff/21001/22001 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java (right): http://codereview.appspot.com/2104046/diff/21001/22001#newcode188 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java:188: * GagdetContext implementation for JsHandler which is called by FeatureResgistry. On 2010/09/04 06:30:54, Paul Lindner wrote: > spelling nit... s/Resgistry/Registry/ Sorry, will fix the spelling errors =( http://codereview.appspot.com/2104046/diff/21001/22001#newcode199 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java:199: public RenderingContext getRenderingContext() { On 2010/09/04 06:30:54, Paul Lindner wrote: > extra indent here.. Fixed it, thank you. http://codereview.appspot.com/2104046/