shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From henry.sapu...@gmail.com
Subject Re: Separate JS content processing logic from JsServlet (issue2104046)
Date Sat, 04 Sep 2010 06:54:39 GMT
Resolve issue/suggestions from Paul.

Uploaded the latest patch file.

- Henry


http://codereview.appspot.com/2104046/diff/21001/22001
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java
(right):

http://codereview.appspot.com/2104046/diff/21001/22001#newcode188
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java:188:
* GagdetContext implementation for JsHandler which is called by
FeatureResgistry.
On 2010/09/04 06:30:54, Paul Lindner wrote:
> spelling nit... s/Resgistry/Registry/

Sorry, will fix the spelling errors =(

http://codereview.appspot.com/2104046/diff/21001/22001#newcode199
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java:199:
public RenderingContext getRenderingContext() {
On 2010/09/04 06:30:54, Paul Lindner wrote:
> extra indent here..

Fixed it, thank you.

http://codereview.appspot.com/2104046/

Mime
View raw message