Return-Path: Delivered-To: apmail-shindig-dev-archive@www.apache.org Received: (qmail 61390 invoked from network); 1 Jul 2010 19:18:00 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 1 Jul 2010 19:18:00 -0000 Received: (qmail 69877 invoked by uid 500); 1 Jul 2010 19:17:58 -0000 Delivered-To: apmail-shindig-dev-archive@shindig.apache.org Received: (qmail 69415 invoked by uid 500); 1 Jul 2010 19:17:57 -0000 Mailing-List: contact dev-help@shindig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shindig.apache.org Delivered-To: mailing list dev@shindig.apache.org Received: (qmail 69113 invoked by uid 500); 1 Jul 2010 19:17:57 -0000 Delivered-To: apmail-incubator-shindig-dev@incubator.apache.org Received: (qmail 69015 invoked by uid 99); 1 Jul 2010 19:17:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Jul 2010 19:17:57 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of shindig.remailer+caf_=shindig-dev=incubator.apache.org@gmail.com designates 74.125.83.175 as permitted sender) Received: from [74.125.83.175] (HELO mail-pv0-f175.google.com) (74.125.83.175) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Jul 2010 19:17:50 +0000 Received: by pvg13 with SMTP id 13so1065769pvg.6 for ; Thu, 01 Jul 2010 12:16:29 -0700 (PDT) Received: by 10.142.74.17 with SMTP id w17mr13159684wfa.195.1278011789026; Thu, 01 Jul 2010 12:16:29 -0700 (PDT) X-Forwarded-To: shindig-dev@incubator.apache.org X-Forwarded-For: shindig.remailer@gmail.com shindig-dev@incubator.apache.org Delivered-To: shindig.remailer@gmail.com Received: by 10.142.80.13 with SMTP id d13cs38817wfb; Thu, 1 Jul 2010 12:16:27 -0700 (PDT) Received-SPF: pass (google.com: domain of 3i-ksTAcJEO0oWdgThWVbPXa.RdbhWXcSXV.gTbPXaTgVbPXa.Rdb@ZtVtWrE11C56Zw4yjiZh12.apphosting.bounces.google.com designates 10.142.151.41 as permitted sender) client-ip=10.142.151.41; Authentication-Results: mr.google.com; spf=pass (google.com: domain of 3i-ksTAcJEO0oWdgThWVbPXa.RdbhWXcSXV.gTbPXaTgVbPXa.Rdb@ZtVtWrE11C56Zw4yjiZh12.apphosting.bounces.google.com designates 10.142.151.41 as permitted sender) smtp.mail=3i-ksTAcJEO0oWdgThWVbPXa.RdbhWXcSXV.gTbPXaTgVbPXa.Rdb@ZtVtWrE11C56Zw4yjiZh12.apphosting.bounces.google.com Received: from mr.google.com ([10.142.151.41]) by 10.142.151.41 with SMTP id y41mr2794399wfd.42.1278011787170 (num_hops = 1); Thu, 01 Jul 2010 12:16:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.151.41 with SMTP id y41mr2522071wfd.42.1278011787051; Thu, 01 Jul 2010 12:16:27 -0700 (PDT) Reply-To: jtarrio@gmail.com, zhoresh@gmail.com, shindig.remailer@gmail.com, reply@codereview.appspotmail.com X-Google-Appengine-App-Id: codereview Message-ID: <000e0cd148c89605d6048a584e39@google.com> Date: Thu, 01 Jul 2010 19:16:27 +0000 Subject: Re: Check the correct attribute of OAuthErrors (issue1704045) From: zhoresh@gmail.com To: jtarrio@gmail.com, shindig.remailer@gmail.com Cc: reply@codereview.appspotmail.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes X-Virus-Checked: Checked by ClamAV on apache.org lgtm, basically use the correct error name in comparison Committing http://codereview.appspot.com/1704045/show