shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pan Jie (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SHINDIG-541) Tiered message bundles
Date Tue, 02 Dec 2008 02:59:44 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652249#action_12652249
] 

Pan Jie commented on SHINDIG-541:
---------------------------------

Hi, there is an error in impetus's patch. There is a failure case for his patch. Suppose lang
= en and country = US, when message "test" exist in en_ALL.xml but doesn't exist in en_US.xml
and ALL_ALL.xml, gadgets couldn't retrieve message "test".
I have made a patch to fix this issue. Here are changes to impetus's patch:
1. Fixed an error when implementing message fallback.
2. Used multiFetch instead of single fetch.
3. Fixed a failed unittest.

> Tiered message bundles 
> -----------------------
>
>                 Key: SHINDIG-541
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-541
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadget Rendering Server (PHP)
>            Reporter: Chris Chabot
>            Priority: Critical
>         Attachments: 20081201.patch, GadgetServer.php.patch, MessageBundleParser.php.patch
>
>
> Currently shindig uses only one localization pack (whichever language pack matches the
preffered language the closest), and uses only that for message tag substitution.
> However the correct behavior should be that if a translation tag (__MSG_foo) is not found
in the active language set, it should try the the next best match (so first en-US, then en-ALL,
then ALL-ALL if the previous 2 failed) and use that for translation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message