shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chico charlesworth" <chico.charleswo...@googlemail.com>
Subject Re: [jira] Commented: (SHINDIG-718) Building shindig from behind a proxy fails
Date Wed, 03 Dec 2008 09:19:55 GMT
Is anyone working on issue JIRA-718? I see the Provider<Proxy> code was
initially added from a patch from Rodrigo, so perhaps Rodrigo would be the
best person to decide what's the best approach on this one?

2008/12/2 Louis Ryan (JIRA) <jira@apache.org>

>
>    [
> https://issues.apache.org/jira/browse/SHINDIG-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652316#action_12652316]
>
> Louis Ryan commented on SHINDIG-718:
> ------------------------------------
>
> It would seem more consistent to always bind an instance of ProxySelector
> rather than Provider<Proxy> and then use
>
> List<Proxy> proxies = selector.select(url.toURI());
> if (proxies.isEmpty()) {
>  ...  url.openConnection();
> } else {
>  ... url.openConnection(proxies.get(0));
> }
>
> not sure but if select always returns a non empty list then the if-else can
> be simplified.
>
>
>
> > Building shindig from behind a proxy fails
> > ------------------------------------------
> >
> >                 Key: SHINDIG-718
> >                 URL: https://issues.apache.org/jira/browse/SHINDIG-718
> >             Project: Shindig
> >          Issue Type: Bug
> >          Components: Common Components (Java)
> >         Environment: Behind a proxy
> >            Reporter: Chico Charlesworth
> >         Attachments: fix-proxy-bug.patch
> >
> >
> > When the maven build runs behind a proxy the test
> EndToEndTest.testTemplates() fails.
> > i.e. mvn clean install -Dhttp.proxyHost=<host> -Dhttp.proxyPort=<port>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message