shindig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rodrigo Gallardo (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SHINDIG-718) Building shindig from behind a proxy fails
Date Wed, 03 Dec 2008 14:53:45 GMT

    [ https://issues.apache.org/jira/browse/SHINDIG-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652816#action_12652816
] 

Rodrigo Gallardo commented on SHINDIG-718:
------------------------------------------

Actually, url.openConnection() calls ProxySelector.getDefault().select(...), so injecting
our own would only replicate badly the logic that's already in the JVM. Moreover, if someone
goes to the trouble of setting up a ProxySelector, setting it up with ProxySelector.setDefault()
seems no more complicated than setting a binding for it in a Guice Module.

It seems that binding the Provider<Proxy> is failing because of http://code.google.com/p/google-guice/issues/detail?id=107

As I see no easy way to fix this, and given how using a ProxySelector instead of this injection
ought to be simple enough, I recommend we withdraw completely my original patch from https://issues.apache.org/jira/browse/SHINDIG-701

> Building shindig from behind a proxy fails
> ------------------------------------------
>
>                 Key: SHINDIG-718
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-718
>             Project: Shindig
>          Issue Type: Bug
>          Components: Common Components (Java)
>         Environment: Behind a proxy
>            Reporter: Chico Charlesworth
>         Attachments: fix-proxy-bug.patch
>
>
> When the maven build runs behind a proxy the test EndToEndTest.testTemplates() fails.
> i.e. mvn clean install -Dhttp.proxyHost=<host> -Dhttp.proxyPort=<port>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message