shenyu-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-shenyu] kevinw66 commented on a change in pull request #1663: [ISSUE #1662] Fix check url return false
Date Wed, 23 Jun 2021 06:53:17 GMT

kevinw66 commented on a change in pull request #1663:
URL: https://github.com/apache/incubator-shenyu/pull/1663#discussion_r656809219



##########
File path: shenyu-common/src/main/java/org/apache/shenyu/common/utils/UpstreamCheckUtils.java
##########
@@ -57,32 +65,15 @@ public static boolean checkUrl(final String url) {
         }
         final boolean isHttps = url.startsWith(HTTPS);
         final int port = hostPort.length > 1 ? Integer.parseInt(hostPort[1]) : isHttps
? 443 : 80;
-        if (checkIP(hostPort[0]) || isHttps) {

Review comment:
       We will use `80` as default port and check the port is open or not. Since the UpstreamCheckUtils
is only use for divide plugin for now, I think this is reasonable. What's your opinion ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message