shale-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Gomm (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SHALE-386) Have to execute action twice to return to calling dialog
Date Wed, 18 Apr 2007 12:02:43 GMT

    [ https://issues.apache.org/struts/browse/SHALE-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40833
] 

Nick Gomm commented on SHALE-386:
---------------------------------

In my test system I have a fix for this.  I updated the "advance" method in "org.apache.shale.dialog.basic.BasicDialogContext"
to include the following in the while loop where the state is an EndState just before the
break

               .....
                viewId = ((EndState) state).getViewId();
                redirect = ((EndState) state).isRedirect();

                // if we do not have a view and we are a sub dialog we need to
                // advance the calling dialog
                if ( viewId == null && positions.size()>=1 )  {
                    advance(context, outcome);
                    return;
                }

                break;

Not sure how to go about offering the fix to the project so I'm just adding this comment.

> Have to execute action twice to return to calling dialog
> --------------------------------------------------------
>
>                 Key: SHALE-386
>                 URL: https://issues.apache.org/struts/browse/SHALE-386
>             Project: Shale
>          Issue Type: Bug
>          Components: Dialog
>    Affects Versions: 1.1.0-SNAPSHOT
>         Environment: Windows XP, Weblogic 8.1, snapshot 20070103
>            Reporter: Adam A. Koch
>         Attachments: bwa.war
>
>
> I have to run an action twice to be returned to the calling dialog.
> Steps to recreate:
> Click on Go to Dialog 1
> Click on Go to Dialog 2
> Click on Cancel
> Expect to go to "Returned from subdialog" screen instead am presented with the same screen.
> Click on Cancel (again)
> I get the expected behavior and am sent to "Returned from subdialog" screen

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message