shale-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Chasman (JIRA)" <j...@apache.org>
Subject [jira] Created: (SHALE-405) Incorrect logic in MockApplication12.addELResolver(ELResolver resolver)
Date Sun, 04 Feb 2007 16:15:16 GMT
Incorrect logic in MockApplication12.addELResolver(ELResolver resolver)
-----------------------------------------------------------------------

                 Key: SHALE-405
                 URL: https://issues.apache.org/struts/browse/SHALE-405
             Project: Shale
          Issue Type: Bug
          Components: Test
    Affects Versions: 1.1.0-SNAPSHOT
         Environment: Not environment specific
            Reporter: Doug Chasman
            Priority: Blocker


Current implementation will never allow addition of el resolvers regardless of the point in
the app lifecycle:

    /** {@inheritDoc} */
    public void addELResolver(ELResolver resolver) {

        // Simulate the restriction that you cannot add resolvers after
        // the first request has been processed.
        if (resolver != null) {
            throw new IllegalStateException("Cannot add resolvers now");
        }

        resolvers.add(resolver);

    }

should read:

    /** {@inheritDoc} */
    public void addELResolver(ELResolver resolver) {

        // Simulate the restriction that you cannot add resolvers after
        // the first request has been processed.
        if (this.resolver != null) {
            throw new IllegalStateException("Cannot add resolvers now");
        }

        resolvers.add(resolver);

    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message