shale-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary VanMatre (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SHALE-340) Catch-all for general improvements and documentation for shale-validator
Date Fri, 24 Nov 2006 17:01:57 GMT
    [ http://issues.apache.org/struts/browse/SHALE-340?page=comments#action_38844 ] 
            
Gary VanMatre commented on SHALE-340:
-------------------------------------

I think these are all good ideas.  Here are obviously issues with the clutter 
that is distracting from the features.  Having a validator subclass for each 
type of rule would be more of a JSF way.  

Moving the validator logic to helper classes would also allow people to use it 
in the validator property binding callbacks.  And, the script component could be 
automatically added using the renderer decorator approach on the form renderer.  
The solution for evaluation of client side validator value binding expressions 
in a UIData subclass. 

I was not happy with the extra validator XML form use to describe the formal and 
actual parameters and the message parameters.  I wanted to use as much of the 
existing shale and commons implementation.  If we created wrapper callbacks like 
in struts, we wouldn't need this extra information but it's not as configurable.  
At the time, no one else had additional ideas so I just went with it.



> Catch-all for general improvements and documentation for shale-validator
> ------------------------------------------------------------------------
>
>                 Key: SHALE-340
>                 URL: http://issues.apache.org/struts/browse/SHALE-340
>             Project: Shale
>          Issue Type: Improvement
>          Components: Validator
>            Reporter: Craig McClanahan
>         Assigned To: Craig McClanahan
>            Priority: Minor
>             Fix For: 1.0.4-SNAPSHOT
>
>
> Catch-all ticket for general improvements to shale-validator that are surfaced during
the creation and testing of a new integration test webapp (SHALE-399)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message