Return-Path: Delivered-To: apmail-shale-issues-archive@locus.apache.org Received: (qmail 78053 invoked from network); 28 Sep 2006 02:27:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 28 Sep 2006 02:27:24 -0000 Received: (qmail 50286 invoked by uid 500); 28 Sep 2006 02:27:24 -0000 Delivered-To: apmail-shale-issues-archive@shale.apache.org Received: (qmail 50259 invoked by uid 500); 28 Sep 2006 02:27:23 -0000 Mailing-List: contact issues-help@shale.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@shale.apache.org Delivered-To: mailing list issues@shale.apache.org Received: (qmail 50250 invoked by uid 99); 28 Sep 2006 02:27:23 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Sep 2006 19:27:23 -0700 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= Received: from [209.237.227.198] ([209.237.227.198:49223] helo=brutus.apache.org) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id A4/43-04219-9033B154 for ; Wed, 27 Sep 2006 19:27:21 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id ABE9A7141BB for ; Thu, 28 Sep 2006 02:23:31 +0000 (GMT) Message-ID: <31143104.1159410211686.JavaMail.jira@brutus> Date: Wed, 27 Sep 2006 19:23:31 -0700 (PDT) From: "Gary VanMatre (JIRA)" To: issues@shale.apache.org Subject: [jira] Commented: (SHALE-292) Clay doesn't consider file's encoding when loading/parsing html templates from hdd In-Reply-To: <10890043.1159203871637.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/struts/browse/SHALE-292?page=comments#action_38283 ] Gary VanMatre commented on SHALE-292: ------------------------------------- This is the first try at resolving this issue. It will be available in the shale-framework-20060928 nightly build. You can find it here: http://people.apache.org/builds/shale/nightly/. To summarize the changes based on your notes the encoding is now determined with the following steps: 1) Look at the top of the template for the token comment containing the charset. For example: <-- ### clay:page charset="UTF-8" /### --> 2) If not found, look for the app wide config option for template encoding. If found use the encoding for reading the template. For example:

org.apache.shale.clay.HTML_TEMPLATE_CHARSET

UTF-8

3) If not found use the vm's default "file.encoding". 4) Read the template in with the determined encoding Tom, I'm going to leave this open until you have a chance to verify. > Clay doesn't consider file's encoding when loading/parsing html templates from hdd > ---------------------------------------------------------------------------------- > > Key: SHALE-292 > URL: http://issues.apache.org/struts/browse/SHALE-292 > Project: Shale > Issue Type: Bug > Components: Clay > Affects Versions: 1.0.0, 1.0.1, 1.0.2, 1.0.4-SNAPSHOT, 1.0.3 > Environment: windows xp, tomcat 5.5 (started with -Dfile.encoding=UTF-8 option, this way myfaces doesn't convert all non-ascii characters to html entities), myfaces 1.1.3 > Reporter: Tom Pasierb > Assigned To: Gary VanMatre > Attachments: some.html, whatever.jsp > > > Clay reads html files assuming ascii encoding. This way it's impossible to have characters other than ascii in templates. They do not display correctly. As indicated on the user mailing list a Reader object should be used for reading templates instead of InputStream. I wrote more about this on shale user mailing list. > We probably need: > 1. app wide config option for setting encoding clay should use for reading templates in. Clay would default to this setting unless maybe > 2. some per file encoding config option was set (something similar to @page pageEncoding directive for jsps) > I marked it as major as this should be corrected if one wants to develop localized applications with non-ascii characters in html templates. > As noted by Craig this probably also applies to xml templates, which I haven't tried myself. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira