shale-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Pasierb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SHALE-292) Clay doesn't consider file's encoding when loading/parsing html templates from hdd
Date Wed, 27 Sep 2006 06:39:31 GMT
    [ http://issues.apache.org/struts/browse/SHALE-292?page=comments#action_38276 ] 
            
Tom Pasierb commented on SHALE-292:
-----------------------------------

This sounds like a good idea.

However, It would be nice to have an extra application wide config option for loading html
templates. The proccessing would look like this:

1) Look at the top of the template for the token comment containing the charset. If not found,
2) look for the app wide config option for template encoding. If found use the encoding for
reading the template, If not found use the vm's default "file.encoding".
3) Read the template in with the determined encoding

This way one could have all the templates in a given encoding and unless there was <!--
### clay:page charset="UTF-8" / --> directive at the top of the file, they would be read
with the default encoding set in web.xml and one wouldn't have to define this config in each
and every template file. If no <!-- ### clay:page charset="UTF-8" / --> directive was
defined in web.xml (null) then clay would fall back to vm'a default file.encoding

How about this?


> Clay doesn't consider file's encoding when loading/parsing html templates from hdd
> ----------------------------------------------------------------------------------
>
>                 Key: SHALE-292
>                 URL: http://issues.apache.org/struts/browse/SHALE-292
>             Project: Shale
>          Issue Type: Bug
>          Components: Clay
>    Affects Versions: 1.0.0, 1.0.1, 1.0.2, 1.0.4-SNAPSHOT, 1.0.3
>         Environment: windows xp, tomcat 5.5 (started with -Dfile.encoding=UTF-8 option,
this way myfaces doesn't convert all non-ascii characters to html entities), myfaces 1.1.3
>            Reporter: Tom Pasierb
>         Assigned To: Gary VanMatre
>         Attachments: some.html, whatever.jsp
>
>
> Clay reads html files assuming ascii encoding. This way it's impossible to have characters
other than ascii in templates. They do not display correctly. As indicated on the user mailing
list a Reader object should be used for reading templates instead of InputStream. I wrote
more about this on shale user mailing list.
> We probably need:
> 1. app wide config option for setting encoding clay should use for reading templates
in. Clay would default to this setting unless maybe
> 2. some per file encoding config option was set (something similar to @page pageEncoding
directive for jsps)
> I marked it as major as this should be corrected if one wants to develop localized applications
with non-ascii characters in html templates.
> As noted by Craig this probably also applies to xml templates, which I haven't tried
myself.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message