shale-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hermod Opstvedt <her...@opstvedt.com>
Subject SV: Clay, Tomahawk and jscookmenu
Date Tue, 16 Jan 2007 19:38:03 GMT
Hi

Ok, I'm finally having some spare time to look into this. It's no problem
getting the rendererType from components that extend UIComponentTag. Now
where do we want to put it in the clay-config?

1. 
<component jsfid="view" componentType="javax.faces.ViewRoot"
rendererType="....">

2.
  <component jsfid="view" componentType="javax.faces.ViewRoot">
     <attributes>
         ...
         <set name=" rendererType " value="..." />	
         ...
  </component>

I would guess that 1 is the preferred choice, although that will mean that
we need to change the dtd.

Hermod


-----Opprinnelig melding-----
Fra: Hermod Opstvedt [mailto:hermod@opstvedt.com] 
Sendt: 18. desember 2006 17:43
Til: user@shale.apache.org
Emne: SV: Clay, Tomahawk and jscookmenu

Hi

I'll take a look at it.

Hermod


-----Opprinnelig melding-----
Fra: Gary VanMatre [mailto:gvanmatre@comcast.net] 
Sendt: 18. desember 2006 17:03
Til: user@shale.apache.org
Emne: RE: Clay, Tomahawk and jscookmenu

>From: <hermod.opstvedt@dnbnor.no> 
>
> Hi 
> 
> Gary, is this something that we need to adress in the Tld2Clayconfig tool 
> (rendertype) ? 
>

That's not a bad idea.  If we pulled the rendererType from the Tag, it
should
fix these components that are loose (with the rendererType).


 
> Hermod 
>

Gary
 
> -----Original Message----- 
> From: Gary VanMatre [mailto:gvanmatre@comcast.net] 
> Sent: Sunday, December 17, 2006 11:59 PM 
> To: user@shale.apache.org 
> Subject: Re: Clay, Tomahawk and jscookmenu 
> 
> 
> >From: "Steve Olson" 
> > 
> > Thanks for the info. I looked at both the code below and your site, and
> have 
> a couple questions. It looks like you had to essentially render your 
> > own menu, as if the jscookmenu renderer wasn't used. Also the call to 
> > cmDrawFromText - the jscookmenu.js that comes with the tomahawk 1.1.3
jar > 
> doesn't seem to define cmDrawFromText. I can see on the jscook site that >
this 
> is a valid function so are you using a newer jscook version than the 
> > tomhawk jar does, or am I just missing something? 
> > 
> > Also, it looked like you had to extract the resources (.js, .gif, etc)
for 
> > jscookmenu from the tomahawk jar into your own directories and
explicitly > 
> include them, as if org.apache.myfaces.webapp.filter.ExtensionsFilter also

> > wasn't working. Is that what you had to do? Am I understanding things 
> > correctly here? 
> > 
> > I was hoping to get html something like this working, but this just
renders 
> > a default submit Query button as an input control (!?): 
> > 
> > > theme="ThemeOffice"> 
> > 
> > > itemValue="#{messages['menu1']}" action="#{homePage.menu1}"/> 
> > 
> > > itemValue="#{messages['menu2']}" action="#{homePage.menu2}"/> 
> > 
> > 
> > 
> > It'd be nice if this would rely on the tomahawk infastructure to provide
the 
> > same rendering it does without using Clay. Is there a conflict/bug here
> 
> between Clay and tomahawk with how it renders jscookmenu controls? 
> > 
> > If this is a bug or an RFE, I don't see anything listed in the Shale
Jira. 
> > I'm also assuming this is a Clay issue, since it works in JSP, but maybe
> 
> that's a bad assumption :-). Anyway, I have some time available and would 
> > be interested in contributing a patch (assuming I can figure one out :-)
if 
> > that would be useful. 
> > 
> > Do you agree that this is a Clay bug? Do you know of anyone else already
> 
> looking into this? Should this be a new clay Jira issue? 
> > 
> 
> It looks like there are a couple issue here. The first is that the
renderType 
> of the jscookMenu is lost. Some of the myfaces tomahawk components 
> don't return / override the renderType. In this case it's picking up a
default 
> button renderType. 
> 
> This can be easily fixed by overriding it in the Clay conifg. We will need
to 
> change this in the base tomahawk 1.3 config but consider the following
example: 
> 
> 
> 
> 
> 
> 
> 
> The next problem is that the javascript is not being added. I tracked this
down 
> to the myfaces ExtensionsFilter. The filter injects javascript into the 
> response but it's insistent that the response's contentType is set so it
can 
> determine if it should process the resource for insertion. The 
> ClayViewHander is not explicitly setting the response's content type. 
> 
> You have uncovered a couple bugs here. Please create a JIRA ticket 
> on this one (http://shale.apache.org/issue-tracking.html). I'd like to get
a 
> fix in before the next shale release. 
> 
> 
> Gary 
> 
> 
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
* 
> 
> This email with attachments is solely for the use of the individual or 
> entity to whom it is addressed. Please also be aware that DnB NOR cannot 
> accept any payment orders or other legally binding correspondence with 
> customers as a part of an email. 
> 
> This email message has been virus checked by the anti virus programs used 
> in the DnB NOR Group. 
> 
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
* 
> 


Mime
View raw message