From dev-return-1943-archive-asf-public=cust-asf.ponee.io@servicecomb.apache.org Wed Feb 7 10:17:00 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 09E5518065B for ; Wed, 7 Feb 2018 10:17:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id ED298160C5B; Wed, 7 Feb 2018 09:16:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 37B37160C3C for ; Wed, 7 Feb 2018 10:16:59 +0100 (CET) Received: (qmail 46942 invoked by uid 500); 7 Feb 2018 09:16:58 -0000 Mailing-List: contact dev-help@servicecomb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@servicecomb.apache.org Delivered-To: mailing list dev@servicecomb.apache.org Received: (qmail 46931 invoked by uid 99); 7 Feb 2018 09:16:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Feb 2018 09:16:58 +0000 From: GitBox To: dev@servicecomb.apache.org Subject: [GitHub] jeho0815 commented on a change in pull request #549: [SCB-315] Resolve the Registry-Service UT test fail Message-ID: <151799501785.18761.7303901295507147740.gitbox@gitbox.apache.org> jeho0815 commented on a change in pull request #549: [SCB-315] Resolve the Registry-Service UT test fail URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/549#discussion_r166557108 ########## File path: foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java ########## @@ -109,9 +109,12 @@ public static AddressResolverOptions getAddressResover(String tag, Configuration private static List getStringListProperty(Configuration configSource, List defaultValue, String... keys) { - if (configSource == null) { + if (configSource == null && DynamicPropertyFactory.getBackingConfigurationSource() != null) { Review comment: ok ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services