servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)
Date Thu, 01 Jan 1970 00:00:00 GMT
zhengyangyong commented on a change in pull request #555: [SCB-327] Update metrics publish
data module (Re-organized)
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r169550013
 
 

 ##########
 File path: metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/monitor/ConsumerInvocationMonitor.java
 ##########
 @@ -17,11 +17,12 @@
 
 package org.apache.servicecomb.metrics.core.monitor;
 
+import java.util.HashMap;
+import java.util.Map;
 
-import org.apache.servicecomb.metrics.common.ConsumerInvocationMetric;
-import org.apache.servicecomb.metrics.common.MetricsConst;
+import org.apache.servicecomb.foundation.metrics.MetricsConst;
 
-public class ConsumerInvocationMonitor extends InvocationMonitor {
+public class ConsumerInvocationMonitor {
 
 Review comment:
   I had use DefaultMonitorRegistry as monitor container replace it;
   In order to update monitor,I had add a group of basic wrapped monitor extends from AbstractMonitor;
   Measure metrics will direct from DefaultMonitorRegistry.getInstance().getRegisteredMonitors()
then getValue()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message