servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] WillemJiang commented on a change in pull request #549: [SCB-315] Resolve the Registry-Service UT test fail
Date Thu, 01 Jan 1970 00:00:00 GMT
WillemJiang commented on a change in pull request #549: [SCB-315] Resolve the Registry-Service
UT test fail
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/549#discussion_r165916277
 
 

 ##########
 File path: foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
 ##########
 @@ -109,9 +109,12 @@ public static AddressResolverOptions getAddressResover(String tag, Configuration
 
   private static List<String> getStringListProperty(Configuration configSource,
       List<String> defaultValue, String... keys) {
-    if (configSource == null) {
+    if (configSource == null && DynamicPropertyFactory.getBackingConfigurationSource()
!= null) {
 
 Review comment:
   There are lot of duplicated code, we could extract a method for it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message