servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] wujimin commented on a change in pull request #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto?
Date Thu, 01 Jan 1970 00:00:00 GMT
wujimin commented on a change in pull request #546: SCB-315 Config Center module can't get
config by DynamicPropertyFacto?
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#discussion_r165800125
 
 

 ##########
 File path: foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
 ##########
 @@ -95,33 +127,55 @@ public static AddressResolverOptions getAddressResover(String tag) {
     }
   }
 
-  private static int getIntProperty(int defaultValue, String... keys) {
+  private static int getIntProperty(ConcurrentCompositeConfiguration configSource, int defaultValue,
String... keys) {
 
 Review comment:
   we can make the logics simpler

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message