servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] yhs0092 commented on a change in pull request #542: [SCB-322] merge config center modification
Date Thu, 01 Jan 1970 00:00:00 GMT
yhs0092 commented on a change in pull request #542: [SCB-322] merge config center modification
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/542#discussion_r165259526
 
 

 ##########
 File path: dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterConfig.java
 ##########
 @@ -110,6 +121,26 @@ public int getFirstRefreshInterval() {
     return finalConfig.getInt(FIRST_REFRESH_INTERVAL, DEFAULT_FIRST_REFRESH_INTERVAL);
   }
 
+  public Boolean isProxyEnable() {
+    return finalConfig.getBoolean(PROXY_ENABLE, false);
+  }
+
+  public String getProxyHost() {
+    return finalConfig.getString(PROXY_HOST, "127.0.0.1");
+  }
+
+  public int getProxyPort() {
+    return finalConfig.getInt(PROXY_PORT, 8080);
+  }
+
+  public String getProxyUsername() {
+    return finalConfig.getString(PROXY_USERNAME, "user");
 
 Review comment:
   I've set the default value of PROXY_USER and PROXY_PASSWD to "" now, please review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message