servicecomb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #697: [Enhancement] implement ms datasource register service in etcd mode
Date Fri, 25 Sep 2020 01:45:04 GMT

tianxiaoliang commented on a change in pull request #697:
URL: https://github.com/apache/servicecomb-service-center/pull/697#discussion_r494700397



##########
File path: server/service/ms/datasource.go
##########
@@ -18,10 +18,11 @@ package ms
 import (
 	"context"
 	pb "github.com/apache/servicecomb-service-center/pkg/registry"
+	"github.com/apache/servicecomb-service-center/server/plugin/registry"
 )
 
 type DataSource interface {
-	RegisterService(ctx context.Context, service *pb.CreateServiceRequest) (*pb.CreateServiceResponse,
error)
+	RegisterService(ctx context.Context, service *pb.CreateServiceRequest) (*registry.PluginResponse,
error)

Review comment:
       why? PluginResponse is a kv spec ,why not use bizz model




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message