sentry-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Na Li (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SENTRY-1502) Multiple tests in TestSentryStore are not testing useful things
Date Thu, 13 Sep 2018 16:53:00 GMT

     [ https://issues.apache.org/jira/browse/SENTRY-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Na Li updated SENTRY-1502:
--------------------------
    Fix Version/s:     (was: 2.1.0)

> Multiple tests in TestSentryStore are not testing useful things
> ---------------------------------------------------------------
>
>                 Key: SENTRY-1502
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1502
>             Project: Sentry
>          Issue Type: Test
>          Components: Sentry
>    Affects Versions: 1.7.0, 2.0.0
>            Reporter: Alexander Kolbasov
>            Assignee: Ruiming Zhou
>            Priority: Major
>              Labels: patch
>         Attachments: SENTRY-1502.001.patch
>
>
> I noticed that multiple unit tests in TestSentryStore are not testing useful things.
For example:
> {code}
> @Test
>   public void testCreateDropRole() throws Exception {
>     String roleName = "test-drop-role";
>     long seqId = sentryStore.createSentryRole(roleName).getSequenceId();
>     assertEquals(seqId + 1, sentryStore.dropSentryRole(roleName).getSequenceId());
>   }
> {code}
> So this code only tests that there are no exceptions thrown. The assert is bogus - it
tests that there was a single transaction in between which is a wrong test in the first place
- number of transactions isn't a functionality. The test doesn't verify whether the role was
actually created and whether it was correctly dropped. And it is similar for other tests as
well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message