From issues-return-14393-archive-asf-public=cust-asf.ponee.io@sentry.apache.org Wed Jun 20 17:07:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A773B18067A for ; Wed, 20 Jun 2018 17:07:04 +0200 (CEST) Received: (qmail 83046 invoked by uid 500); 20 Jun 2018 15:07:03 -0000 Mailing-List: contact issues-help@sentry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@sentry.apache.org Received: (qmail 83033 invoked by uid 99); 20 Jun 2018 15:07:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2018 15:07:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id F217B180740 for ; Wed, 20 Jun 2018 15:07:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id sWDmbLhKDJ_U for ; Wed, 20 Jun 2018 15:07:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3D4BE5F27D for ; Wed, 20 Jun 2018 15:07:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 78017E0CC5 for ; Wed, 20 Jun 2018 15:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2F9CD2183A for ; Wed, 20 Jun 2018 15:07:00 +0000 (UTC) Date: Wed, 20 Jun 2018 15:07:00 +0000 (UTC) From: "Fahd Siddiqui (JIRA)" To: issues@sentry.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (SENTRY-2269) Make SentryStore pluggable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SENTRY-2269?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165= 18235#comment-16518235 ]=20 Fahd Siddiqui edited comment on SENTRY-2269 at 6/20/18 3:06 PM: ---------------------------------------------------------------- [~akolb] - There is already a disclaimer, along with the {{@Private}}=C2=A0= annotation on the interface that makes it clear that the interface can brea= k at any time.=C2=A0 >>=C2=A0In this case SentryStore=C2=A0*is*=C2=A0the interface and existing = SentryStore is an implementation Agreed. And that's why SentryStoreInterface is simply a reflection of Sentr= yStore.=C2=A0 >>=C2=A0=C2=A0instead of creating=C2=A0{{SentryStoreInterface}}=C2=A0and ha= ving=C2=A0{{SentryStore}}=C2=A0as its implementation it should be another w= ay around This isn't clear to me. What do you mean by "another way around"? Are you s= uggesting to swap the names around, so {{SentryStoreInterface}}=C2=A0to=C2= =A0{{SentryStore}}, and then {{SentryStore}}=C2=A0to=C2=A0{{SentryStoreImpl= =C2=A0}}?=C2=A0 was (Author: fahdsiddiqui): [~akolb] - There is already a disclaimer, along with the {{@Private}}=C2=A0= annotation on the interface that makes it clear that the interface can brea= k at any time.=C2=A0 >>=C2=A0In this case SentryStore=C2=A0*is*=C2=A0the interface and existing = SentryStore is an implementation Agreed. And that's why SentryStoreInterface is simply a reflection of Sentr= yStore.=C2=A0 >>=C2=A0=C2=A0instead of creating=C2=A0{{SentryStoreInterface}}=C2=A0and ha= ving=C2=A0{{SentryStore}}=C2=A0as its implementation it should be another w= ay around This isn't clear to me. What do you mean by "another way around"? Are you s= uggesting to swap the names around, so {{SentryStoreInterface}}=C2=A0-->=C2= =A0{{SentryStore}}, and then {{SentryStore}}=C2=A0-->=C2=A0{{SentryStoreImp= l=C2=A0}}?=C2=A0 > Make SentryStore pluggable > -------------------------- > > Key: SENTRY-2269 > URL: https://issues.apache.org/jira/browse/SENTRY-2269 > Project: Sentry > Issue Type: Improvement > Components: sentrystore > Affects Versions: 2.1.0 > Reporter: Fahd Siddiqui > Assignee: Fahd Siddiqui > Priority: Major > Attachments: SENTRY-2269.1.patch > > > Make SentryStore pluggable so a different implementation can be plugged i= n at run-time using a config property ("sentry.service.sentrystore"), simil= ar to what we have for processor factories.=C2=A0 > This would entail extracting all public methods of SentryStore to a Sentr= yStoreInterface and converting all call sites to program to the interface.= =C2=A0 > It will default to the existing SentryStore. -- This message was sent by Atlassian JIRA (v7.6.3#76005)