sentry-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "kalyan kumar kalvagadda (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SENTRY-2193) Synchronize thrift definition with the generated sources
Date Fri, 30 Mar 2018 13:12:00 GMT

     [ https://issues.apache.org/jira/browse/SENTRY-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

kalyan kumar kalvagadda updated SENTRY-2193:
--------------------------------------------
    Description: 
Current thrift definition is not in-line with the the generated source. I suspect that some
of the commits that performed thrift changes did not commit some of the files that are updated.

This would have been the case as the all the generated files were updated because of the date
change. Committers have an habbit of reverting the changes. In that process some one would
have reverted some of the changes that are made.

Intent of this change is Synchronize thrift definition with the generated sources. Once this
we synchronize them and run below command only changes one should be seeing are the date changes.
 
{noformat}
mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local/
{noformat}

  was:
Current thrift definition is not in-line with the the generated source. I suspect that some
of the commits that performed thrift changes did not commit some of the files that are updated.

This is possible as the all the generated files were updated because of the data change and
the committers have an hobbit of reverting the changes. In that process some one would have
reverted some of the changes that are made.

Intent of this change is Synchronize thrift definition with the generated sources. Once this
we synchronize them and run below command only changes one should be seeing are the date changes.
 
{noformat}
mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local/
{noformat}


> Synchronize thrift definition with the generated sources
> --------------------------------------------------------
>
>                 Key: SENTRY-2193
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2193
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: kalyan kumar kalvagadda
>            Assignee: kalyan kumar kalvagadda
>            Priority: Major
>             Fix For: 2.1.0
>
>
> Current thrift definition is not in-line with the the generated source. I suspect that
some of the commits that performed thrift changes did not commit some of the files that are
updated.
> This would have been the case as the all the generated files were updated because of
the date change. Committers have an habbit of reverting the changes. In that process some
one would have reverted some of the changes that are made.
> Intent of this change is Synchronize thrift definition with the generated sources. Once
this we synchronize them and run below command only changes one should be seeing are the date
changes.
>  
> {noformat}
> mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local/
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message