sentry-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "kalyan kumar kalvagadda (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-2089) Avoid THIRD-PARTY.properties source file being modified on every build
Date Fri, 16 Feb 2018 19:28:00 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367775#comment-16367775
] 

kalyan kumar kalvagadda commented on SENTRY-2089:
-------------------------------------------------

[~xyu2017], [~spena], It should not be ignored as this file gets updated based on the changes
in dependencies. it we exclude it from git we should be good. Code change i've done for SENTRY-2081
does that.

Let me get back on what's wrong here.

> Avoid THIRD-PARTY.properties source file being modified on every build
> ----------------------------------------------------------------------
>
>                 Key: SENTRY-2089
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2089
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.0.0
>            Reporter: Sergio Peña
>            Assignee: Xinran Tinney
>            Priority: Major
>
> Every time I build sentry, I see the following unstaged changes on the master branch:
> {noformat}
> On branch master
> Your branch is up-to-date with 'apache/master'.
> Changes not staged for commit:
>   (use "git add <file>..." to update what will be committed)
>   (use "git checkout -- <file>..." to discard changes in working directory)
>         modified:   sentry-dist/src/license/THIRD-PARTY.properties
> no changes added to commit (use "git add" and/or "git commit -a")
> {noformat}
> We should investigate and avoid modifying such file because sometimes developers may
do mistakes and run {{git add .}} and commit the patch with such new modification committed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message