sentry-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "kalyan kumar kalvagadda (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-2085) Sentry error handling exposes SentryGroupNotFoundException externally
Date Wed, 03 Jan 2018 22:57:00 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310434#comment-16310434
] 

kalyan kumar kalvagadda commented on SENTRY-2085:
-------------------------------------------------

[~zamsden_impala_ad21] Thanks for the contribution.

> Sentry error handling exposes SentryGroupNotFoundException externally
> ---------------------------------------------------------------------
>
>                 Key: SENTRY-2085
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2085
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 2.1.0
>            Reporter: Zach Amsden
>            Assignee: Zach Amsden
>         Attachments: SENTRY-2085.001.patch, SENTRY-2085.002.patch, SENTRY-2085.003.patch,
SENTRY-2085.004.patch, SENTRY-2085.006.patch
>
>
> The fix for SENTRY-769 allowed better differentiation of Sentry errors but also unnecessarily
leaked exceptions outside of well defined API components.  This happens because the exception
chosen, SentryGroupNotFoundException was created of a subclass of RuntimeError, allowing it
to propagate past API boundaries without 'throws' or 'catch' clauses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message