Mailing-List: contact issues-help@sentry.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 3 Nov 2017 23:21:00 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@sentry.apache.org
Message-ID: <JIRA.13113103.1509387134000.148061.1509751260106@Atlassian.JIRA>
In-Reply-To: <JIRA.13113103.1509387134000@Atlassian.JIRA>
References: <JIRA.13113103.1509387134000@Atlassian.JIRA> <JIRA.13113103.1509387134026@jira-lw-us.apache.org>
Subject: [jira] [Commented] (SENTRY-2024) Specify Char Set for
 AUTHZ_OBJ_NAME
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 03 Nov 2017 23:21:04 -0000


    [ https://issues.apache.org/jira/browse/SENTRY-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238565#comment-16238565 ] 

Hadoop QA commented on SENTRY-2024:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12895974/SENTRY-2024.002.patch against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3406/console

This message is automatically generated.

> Specify Char Set for AUTHZ_OBJ_NAME
> -----------------------------------
>
>                 Key: SENTRY-2024
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2024
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.0.0
>            Reporter: Na Li
>            Assignee: Na Li
>            Priority: Critical
>         Attachments: SENTRY-2024.001.patch, SENTRY-2024.001.patch, SENTRY-2024.001.patch, SENTRY-2024.002.patch, SENTRY-2024.002.patch
>
>
> AUTHZ_OBJ_NAME has (384) chars. It is constructed by sentry from notification event as {color:red}DB_NAME + "." + TBL_NAME{color}. To be consistent with hive, sentry should use the same char set as what's used by DB_NAME  and TBL_NAME
> Besides, if its table char set is utf8, the constrain AUTHZOBJNAME will have error  "Specified key was too long; max key length is 767 bytes" for mysql.
> The solution is to specify the char set for this field, so it works for mysql regardless the char set of its table or DB.
> Reference:
> 1) CREATE TABLE AUTHZ_PATHS_MAPPING
>  (
>      AUTHZ_OBJ_ID BIGINT NOT NULL generated always as identity (start with 1),
>      AUTHZ_OBJ_NAME VARCHAR({color:red}384{color}),
>      CREATE_TIME_MS BIGINT NOT NULL
> );
> CREATE UNIQUE INDEX AUTHZOBJNAME ON AUTHZ_PATHS_MAPPING ({color:red}AUTHZ_OBJ_NAME{color});
> 2) AUTHZ_OBJ_NAME  is constructed by sentry from notification event as DB_NAME + "." + TBL_NAME. To be consistent with hive, sentry should use the same char set as what's used by DB_NAME  and TBL_NAME in NotificationProcessor.processAlterTable().
> 3) hive uses latin1 as default charset for notification event.
> CREATE TABLE IF NOT EXISTS `NOTIFICATION_LOG`
> (
>     `NL_ID` BIGINT(20) NOT NULL,
>     `EVENT_ID` BIGINT(20) NOT NULL,
>     `EVENT_TIME` INT(11) NOT NULL,
>     `EVENT_TYPE` varchar(32) NOT NULL,
>     `DB_NAME` varchar(128),
>     `TBL_NAME` varchar(128),
>     `MESSAGE` mediumtext,
>     PRIMARY KEY (`NL_ID`)
> ) ENGINE=InnoDB DEFAULT CHARSET=latin1;
> 4) actual installation shows both fields are in latin1 char set.
> SHOW FULL COLUMNS FROM NOTIFICATION_LOG;
> +------------+--------------+-------------------+------+-----+---------+-------+---------------------------------+---------+
> | Field      | Type         | Collation         | Null | Key | Default | Extra | Privileges                      | Comment |
> +------------+--------------+-------------------+------+-----+---------+-------+---------------------------------+---------+
> | NL_ID      | bigint(20)   | NULL              | NO   | PRI | NULL    |       | select,insert,update,references |         |
> | EVENT_ID   | bigint(20)   | NULL              | NO   |     | NULL    |       | select,insert,update,references |         |
> | EVENT_TIME | int(11)      | NULL              | NO   |     | NULL    |       | select,insert,update,references |         |
> | EVENT_TYPE | varchar(32)  | latin1_swedish_ci | NO   |     | NULL    |       | select,insert,update,references |         |
> | DB_NAME    | varchar(128) | latin1_swedish_ci | YES  |     | NULL    |       | select,insert,update,references |         |
> | TBL_NAME   | varchar(128) | latin1_swedish_ci | YES  |     | NULL    |       | select,insert,update,references |         |
> | MESSAGE    | mediumtext   | latin1_swedish_ci | YES  |     | NULL    |       | select,insert,update,references |         |
> +------------+--------------+-------------------+------+-----+---------+-------+---------------------------------+---------+


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)